Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monorepo: type improvements #3947

Merged
merged 8 commits into from
Apr 1, 2025

Conversation

gabrocheleau
Copy link
Contributor

This PR brings some type improvements to the repository, notably removing a lot of typecasting.

Copy link

codecov bot commented Mar 28, 2025

Codecov Report

Attention: Patch coverage is 85.29412% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.63%. Comparing base (8512301) to head (0456966).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 83.29% <ø> (ø)
blockchain 89.33% <0.00%> (-0.17%) ⬇️
client 68.08% <100.00%> (?)
common 98.49% <ø> (ø)
devp2p 86.73% <ø> (ø)
evm 72.98% <100.00%> (+0.04%) ⬆️
genesis 99.98% <ø> (ø)
mpt 89.76% <100.00%> (ø)
rlp 91.43% <ø> (ø)
statemanager 69.16% <ø> (ø)
tx 90.58% <100.00%> (ø)
util 81.96% <ø> (ø)
vm 57.20% <100.00%> (ø)
wallet 88.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@holgerd77
Copy link
Member

Updated the branch here.

@holgerd77 holgerd77 marked this pull request as ready for review April 1, 2025 13:49
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would cautiously assume we can bring the current set of changes in here without any side effects, all seem very much to stand on their own. Will approve and merge pro-actively, hope that's ok (let me know if it was not).

@holgerd77 holgerd77 merged commit f2b8a17 into master Apr 1, 2025
39 of 41 checks passed
@holgerd77 holgerd77 deleted the typescript/erasable-syntax-improvements branch April 1, 2025 13:50
@gabrocheleau
Copy link
Contributor Author

I would cautiously assume we can bring the current set of changes in here without any side effects, all seem very much to stand on their own. Will approve and merge pro-actively, hope that's ok (let me know if it was not).

Sure! Will resume the work in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants