Implement EXECUTE precompile
#3865
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
acolytec3
force-pushed
the
execute-precompile
branch
from
8292fcd to
5db3a51
Compare
g11tech
reviewed
Apr 2, 2025
| for (const stem of accessedSuffixes.keys()) { | ||
| tree.root(parentStateRoot) | ||
| // Generate proofs for each stem from prestate root | ||
| const proof = await tree.createBinaryProof(hexToBytes(stem)) |
There was a problem hiding this comment.
should we do multiproof instead of per stem proof? (may be later i guess)
There was a problem hiding this comment.
Ideally, yes. We just don't have multiproofs implemented for binary trees yet. This is as rudimentary as it gets.
g11tech
reviewed
Apr 2, 2025
| const BinaryTreeExecutionWitness = ssz.container({ | ||
| stateDiff: ssz.list(1024, StateDiff), // List of state diffs | ||
| parentStateRoot: ssz.bytevector(32), // Parent state root as hex | ||
| proof: ssz.list(256, ProofEntry), // List of proof entries with stems and proof data |
There was a problem hiding this comment.
assuming these are super low test limits
There was a problem hiding this comment.
Yes, completely arbitrary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof-of-concept implementation of the simplest form of the
EXECUTEprecompile proposal, using transaction re-execution for verification of the L2 state transition.The current design expects a trace as an SSZ encoded object that contains a set of transactions (formatted as
eth_calltransactions) and a witness taking the form of a binary merkle tree execution witness modeled largely on the Verkle Execution Witness but with simple merkle proofs instead of a Verkle proof.As a short cut until proper blob referencing is implemented, the trace is stored as a simple bytestring in the EVM and referenced by the
sha256hash of the trace in its bytes serialized form.Additional potential todos