cmdline tests are executed in their respective test directory #15996
+984
−979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clonker
commented
Apr 10, 2025
cameel
previously approved these changes
Apr 22, 2025
test/cmdlineTests.sh
Outdated
| scriptCount="$(echo "${scriptFiles}" | wc -w)" | ||
|
|
||
| inputFiles="$(ls -1 "${tdir}/input."* 2> /dev/null || true)" | ||
| inputFiles="$(ls -1 "./input."* 2> /dev/null || true)" |
There was a problem hiding this comment.
I think we'd be better off without the ./ prefix for input.* and other files from the test dir. Their names are hard-coded, so there's no risk that we get one prefixed with -, which looks like an option name and this prefix does show through in some places. E.g. model_checker_bmc_loop_iterations_no_argument/ output:
Error: the argument ('./input.sol') for option '--model-checker-bmc-loop-iterations' is invalid
Though, TBH it's actually less of an issue than I expected - after going over all the files here I've seen very few of these. This is because we try hard to normalize the paths passed on the CLI.
There was a problem hiding this comment.
Ah yeah that is fair enough, let me fix that!
cameel
force-pushed
the
cmdlineTests_go_to_test_dir
branch
from
27693c6 to
06a9e47
Compare
clonker
force-pushed
the
cmdlineTests_go_to_test_dir
branch
from
06a9e47 to
2fa170e
Compare
cameel
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmdlineTests.shnow changes directory into the respective test directory of the executed tests