Make messages mandatory in errors #15671
Conversation
|
This pull request is stale because it has been open for 14 days with no activity. |
github-actions
bot
added
the
stale
cameel
removed
the
stale
| else if (dynamic_cast<IntegerType const*>(&_to)) | ||
| { | ||
| solUnimplementedAssert(fromCategory != Type::Category::FixedPoint); | ||
| solUnimplementedAssert(fromCategory != Type::Category::FixedPoint, "Fixed point types not implemented."); |
There was a problem hiding this comment.
Can you add a semantic test for this (or any other assert)? The legacy codegen one has a different error message, which is not ideal, but at this point I don't think it makes sense to invest the time in updating them.
|
This pull request is stale because it has been open for 14 days with no activity. |
github-actions
bot
added
the
stale
cameel
removed
the
stale
|
This pull request is stale because it has been open for 14 days with no activity. |
github-actions
bot
added
the
stale
cameel
removed
the
stale
|
This pull request is stale because it has been open for 14 days with no activity. |
github-actions
bot
added
the
stale
cameel
removed
the
stale
Errors shown to the user should always have a message. One situation where it is not always the case now are unimplemented feature errors. Those used to be treated as asserts but often they can actually reach the user. This PR deals with them by either converting to asserts or adding a message. Then makes the message mandatory in
solUnimplemented()/solUnimplementedAssert()and in the error reporter.This partially addresses cases like #15669, which currently get properly reported but in a very confusing way.
I could probably convert many more of these to asserts but in cases where I wasn't sure I decided to err on the side of keeping them as is.