Add test runs with minimum dependency versions #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameel
force-pushed
the
testing-min-dependencies
branch
from
96304a9 to
1ea5caa
Compare
cameel
added
the
has dependencies
cameel
force-pushed
the
testing-min-dependencies
branch
17 times, most recently
from
449743f to
06fdfd0
Compare
cameel
commented
Jan 25, 2025
Comment on lines
19
to
+23
| - node-current: | ||
| run_coveralls: true | ||
| - node-current: | ||
| name: node-current-min-dependencies | ||
| min_dependencies: true |
There was a problem hiding this comment.
For some reason CircleCI decided to change the name of the existing job to node-current-1. Not sure why, this does not happen with node-v12 for example. I tried adding name: node-current but it does not change this.
I guess we'll have to accept this and update the name of the required job in settings if we decide to merge the PR. I think we should make the min-dependencies jobs required as well.
cameel
commented
Jan 25, 2025
There was a problem hiding this comment.
I wish npm had built-in support for this but apparently it does not so it has to be done on our own. I saw an old feature request for npm install --minimum, but it was eventually closed as stale.
…on to use oldest supported dependencies
cameel
force-pushed
the
testing-min-dependencies
branch
from
06fdfd0 to
196f913
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #756.