-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary Hardhat-related CI jobs #754
Conversation
The second commit fixes an unrelated thing in the CI: it assumes that the Hardhat repo only has releases related to Hardhat, but we also publish our plugins releases there. This means that if the latest release is a plugin, the job fails. I fixed that by getting all releases, and getting the first one whose tag starts with The node-v10 job is still failing, but that also seems unrelated to my changes here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much @fvictorio! It looks good to me, except for one small comment :)
Yeah, it is unrelated. I will fix it in a follow up PR, thanks. |
@cameel this cannot be merged because |
That job must be failing because I removed those tests from the Hardhat repo thinking this PR was already merged, sorry about that! |
Required jobs updated. |
As discussed in #752, this removes two Hardhat-related jobs that are not necessary and that will stop working soon when we remove those tests from the Hardhat repo.