Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary Hardhat-related CI jobs #754

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

fvictorio
Copy link
Contributor

As discussed in #752, this removes two Hardhat-related jobs that are not necessary and that will stop working soon when we remove those tests from the Hardhat repo.

@coveralls
Copy link

coveralls commented Dec 3, 2024

Coverage Status

coverage: 84.537%. remained the same
when pulling 42d8696 on fvictorio:remove-unnecessary-ci-jobs
into 4aec1e7 on ethereum:master.

@fvictorio
Copy link
Contributor Author

fvictorio commented Dec 3, 2024

The second commit fixes an unrelated thing in the CI: it assumes that the Hardhat repo only has releases related to Hardhat, but we also publish our plugins releases there. This means that if the latest release is a plugin, the job fails.

I fixed that by getting all releases, and getting the first one whose tag starts with hardhat@.

The node-v10 job is still failing, but that also seems unrelated to my changes here.

@cameel cameel requested a review from r0qs December 4, 2024 16:45
Copy link
Member

@r0qs r0qs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @fvictorio! It looks good to me, except for one small comment :)

@r0qs
Copy link
Member

r0qs commented Dec 11, 2024

The node-v10 job is still failing, but that also seems unrelated to my changes here.

Yeah, it is unrelated. I will fix it in a follow up PR, thanks.

@r0qs
Copy link
Member

r0qs commented Jan 23, 2025

@cameel this cannot be merged because hardhat-core-latest-solc is marked as required and I don't have access to the repo settings to change that. Note that this job was removed by this PR ;)

@fvictorio
Copy link
Contributor Author

That job must be failing because I removed those tests from the Hardhat repo thinking this PR was already merged, sorry about that!

@cameel
Copy link
Member

cameel commented Jan 24, 2025

Required jobs updated.

@cameel cameel merged commit 95d3a5f into ethereum:master Jan 24, 2025
13 of 14 checks passed
@fvictorio fvictorio deleted the remove-unnecessary-ci-jobs branch February 25, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants