Skip to content

common: introduce IsHexHash and use it #32998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

common: introduce IsHexHash and use it #32998

wants to merge 1 commit into from
+16 −8

Conversation

@mask-pp
Copy link
Contributor

@mask-pp mask-pp commented Oct 22, 2025

Introduce the IsHexHash method and replace some usages.

MariusVanDerWijden
MariusVanDerWijden approved these changes Oct 23, 2025
View reviewed changes
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its not necessary, but since we have IsHexAddress already, I think its fine

@mask-pp
Copy link
Contributor Author

mask-pp commented Oct 24, 2025

Its not necessary, but since we have IsHexAddress already, I think its fine

Thanks, I found some sub-commands need to check the hash parameter, so I created this PR to simplify the check logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MariusVanDerWijden MariusVanDerWijden MariusVanDerWijden approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mask-pp @MariusVanDerWijden