Skip to content

Conversation

Tristan-Wilson
Copy link
Contributor

Rollups may want to use these to dynamically adjust blobs posted after BPO forks.

Rollups may want to use these to dynamically adjust blobs posted after
BPO forks.
Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MariusVanDerWijden
Copy link
Member

@Tristan-Wilson these methods kinda do the same thing.
I would prefer only to expose the first one (TargetBlobsPerBlock) the others can be easily implemented by the caller.
Also just as a note, we are planning to refactor this part soon in config2 (https://github.com/ethereum/go-ethereum/pull/32224/files) but its still a bit out, so we decided that we would merge this first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants