core/state: parallelize account trie updates in IntermediateRoot #32978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hero5512
changed the title
| // only a single trie is used for state hashing. Replacing a non-nil verkle tree | ||
| // here could result in losing uncommitted changes from storage. | ||
| if s.prefetcher != nil { | ||
| if trie := s.prefetcher.trie(common.Hash{}, s.originalRoot); trie == nil { |
There was a problem hiding this comment.
This step will block until all account prefetching tasks have been fully executed.
Originally, we deliberately processed the storage tries first, followed by the account trie, to give the account prefetcher additional time to complete its work.
However, since #32134 optimized the prefetcher, we now need to measure whether it can finish all tasks at this stage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr tries to close #32922. It refactors IntermediateRoot to parallelize account trie updates, improving performance by hashing the account trie and storage tries concurrently.