Skip to content

internal/jsre: pass only extra args to setTimeout/setInterval callbacks #32936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

internal/jsre: pass only extra args to setTimeout/setInterval callbacks #32936

wants to merge 1 commit into from
+1 −1

Conversation

@anim001k
Copy link

Description

  • Summary: Correct the JS timer callback argument forwarding to match standard JS semantics.
  • What changed: In internal/jsre/jsre.go, the callback is now invoked with only the arguments after the callback and delay.
  • Why: Previously, the callback received the function and delay as parameters, causing unexpected behavior and logic bugs for consumers.

MariusVanDerWijden
MariusVanDerWijden approved these changes Oct 23, 2025
View reviewed changes
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great catch!

@anim001k
Copy link
Author

LGTM, great catch!

@MariusVanDerWijden thanks!

@anim001k
Copy link
Author

@MariusVanDerWijden is it ok to be merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MariusVanDerWijden MariusVanDerWijden MariusVanDerWijden approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anim001k @MariusVanDerWijden