core, eth/tracers: separate dynamic gas reporting #32191
+256
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omerfirmak
requested review from
s1na,
rjl493456442,
MariusVanDerWijden and
lightclient
as code owners
this is in preperation of merging memoryFunc/dynamicGasFunc into executionFuncs
omerfirmak
force-pushed
the
trace-dyn-gas
branch
from
0d6ccb4 to
8dab623
Compare
omerfirmak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is in preperation of merging memoryFunc/dynamicGasFunc into executionFuncs, which will make it not possible to calculate the dynamic gas prior to calling OnOpcode handler.
I tried moving the call to OnOpcode to each of the handlers, but that killed performance.