accounts/abi/bind/v2: modify the default contract deployer to block until the tx is accepted/rejected from the pool #32169
+43
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to fix some flaky tests in this package, and also fixes a valid issue that could affect users.
If the deploy invocation is part of a set of deployments and the nonce is
nil
in theTransactOpts
, the tx nonce will be automatically determined by looking at the pending nonce in the txpool.If there are subsequent dependent deployment transactions, we want to make sure that prior transactions had a chance to be accepted into the pool so that the nonces on all the transactions are set correctly.
TODO: Also, in the case of a multi-contract deployment where
TransactOpts
has non-nil nonce, we should not determine the txs' nonces based on the pending from the pool. Instead, we should start incrementing from whatever was provided in theTransactOpts
.