all: add debug_syncTarget as an API method #32159
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwasinger
requested review from
MariusVanDerWijden,
lightclient,
fjl and
rjl493456442
as code owners
jwasinger
force-pushed
the
debug-sync-target
branch
from
0b9dfbe to
d22a87c
Compare
|
depends on #32149 being merged first. |
jwasinger
force-pushed
the
debug-sync-target
branch
from
a34a0e0 to
cc7bc75
Compare
jwasinger
changed the title
debug_syncTarget
|
Originally this feature is only used for development purpose, which assumes there is no CL attached. |
|
My understanding is that there is the expectation that this is used during an adverse network event where the CL can't track the right chain, and that users (us mostly) would be expected to disconnect the CL and manually set the sync target to keep up with whatever we deem the correct chain to be. |
|
But we could also expand the scope of this to play safely with the engine API. I'm not sure atm what that will entail. |
rjl493456442
added a commit
that referenced
this pull request
Jul 28, 2025
Alternative implementation of #32159
|
Close it in favor of #32177 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes:
SyncTargetmethod on the debug API, reusing the same code path as the--synctargetflag.FullSyncTester->SyncOverrideto better reflect its purpose.SyncOverrideis now a member onEthereum. Move it into theethpackage to prevent a cyclical import (eth->catalyst->eth).