Draft: New EraE implementation #32157

shazam8253 · 2025-07-07T10:54:58Z

Here is a draft for the New EraE implementation. The code follows along with the spec listed at this link.

MariusVanDerWijden

lint is failing, you can check on your machine with make lint

MariusVanDerWijden · 2025-07-07T10:56:13Z

internal/era2/accumulator.go

@@ -0,0 +1,91 @@
+// Copyright 2024 The go-ethereum Authors


Suggested change

// Copyright 2024 The go-ethereum Authors

// Copyright 2025 The go-ethereum Authors

MariusVanDerWijden · 2025-07-07T10:56:31Z

internal/era2/builder2.go

@@ -0,0 +1,305 @@
+package era2


MariusVanDerWijden · 2025-07-07T10:56:43Z

internal/era2/builder2.go

+	receiptoffsets []uint64
+	proofoffsets   []uint64
+	tdoff          []uint64
+	startTd        *big.Int


These are used and implemented, when I am writing sections it also appends with the offset of where item was written.

MariusVanDerWijden · 2025-07-07T10:56:55Z

internal/era2/era2.go

@@ -0,0 +1,429 @@
+package era2


lightclient

Left a bunch of comments here - we still need to figure out how to call this module since era2 isn't very elegant. In the meantime should rename builder2.go to just builder.go and era2.go to era.go.

lightclient · 2025-07-09T14:21:36Z

internal/era2/builder2.go

+	writtenBytes uint64
+}
+
+func NewBuilder(w io.Writer) *Builder {


Please add docs for all public methods

lightclient · 2025-07-09T14:22:53Z

internal/era2/builder2.go

+	}
+}
+
+func (b *Builder) Add(header types.Header, body types.Body, receipts types.Receipts, blockhash common.Hash, blocknum uint64, td *big.Int, proof *Proof) error {


blockhash and blocknum are already available via header, so no need to duplicate them

lightclient · 2025-07-09T14:25:15Z

internal/era2/builder2.go

+	}
+}
+
+func (b *Builder) Add(header types.Header, body types.Body, receipts types.Receipts, blockhash common.Hash, blocknum uint64, td *big.Int, proof *Proof) error {


I would separate this into Add and AddRLP

lightclient · 2025-07-09T14:26:55Z

internal/era2/builder2.go

+	headersRLP  [][]byte
+	bodiesRLP   [][]byte
+	receiptsRLP [][]byte
+	proofsRLP   [][]byte


would remove RLP suffix since it is pretty explanatory by the type [][]byte

internal/era2/builder2.go

lightclient · 2025-07-09T15:35:42Z

internal/era2/era2.go

+	"github.com/klauspost/compress/snappy"
+)
+
+type meta struct {


Suggested change

type meta struct {

type metadata struct {

lightclient · 2025-07-09T15:35:55Z

internal/era2/era2.go

+type meta struct {
+	start     uint64 // start block number
+	count     uint64 // number of blocks in the era
+	compcount uint64 // number of properties


Suggested change

compcount uint64 // number of properties

components uint64 // number of properties

lightclient · 2025-07-09T15:36:04Z

internal/era2/era2.go

+	start     uint64 // start block number
+	count     uint64 // number of blocks in the era
+	compcount uint64 // number of properties
+	filelen   int64  // length of the file in bytes


Suggested change

filelen int64 // length of the file in bytes

length int64 // length of the file in bytes

lightclient · 2025-07-09T15:36:36Z

internal/era2/era2.go

+	mu                                                *sync.Mutex
+	headeroff, bodyoff, receiptsoff, tdoff, proofsoff []uint64 // offsets for each entry type
+	indstart                                          int64
+	rootheader                                        uint64 // offset of the root header in the file if present


what is the use of this?

when reading each era file I load in the index table into cache to make lookup faster, indstart is where the byte where the index table starts, and the root header is where the accumulator root is present when reading so it can seek there quickly since it is its own e2store object. The mutex should be removed though, forgot to do so very early on when I didn't understand what the file was doing I thought I wouldn't want it to read and write at the same time so put a lock.

lightclient · 2025-07-09T15:36:56Z

internal/era2/era2.go

+	m                                                 meta // metadata for the era2 file
+	mu                                                *sync.Mutex
+	headeroff, bodyoff, receiptsoff, tdoff, proofsoff []uint64 // offsets for each entry type
+	indstart                                          int64


what's this?

lightclient · 2025-07-09T15:39:52Z

Also, please write a description for your PRs and try to fix the CI errors so your code is all green.

Fixed all issues including extra logic regarding proof types, modularizing some functions and refactoring code for correctness and readability.

…ments

MariusVanDerWijden · 2025-07-14T18:20:08Z

internal/era2/era.go

+
+func (*BlockProofHistoricalSummariesDeneb) Variant() proofvar { return proofDeneb }
+
+func proofVariantOf(p Proof) proofvar {


Suggested change

func proofVariantOf(p Proof) proofvar {

func variantOf(p Proof) proofvar {

MariusVanDerWijden · 2025-07-14T18:21:25Z

internal/era2/builder.go

@@ -57,41 +57,33 @@ const (

 type proofvar uint16


Suggested change

type proofvar uint16

type variant uint16

We know that the variant is for Proofs, should be at most a comment, not part of the variable name, otherwise you end up with the types like mev-boost :D

gotcha will make the change :)

shantichanal added 5 commits June 26, 2025 14:47

Working on implementation

04baf07

updated some things made a section writer

f44aa8a

finished builder

34640ad

readers for single reads

db4d4dc

sequential access completed (without iterator)

ba32a61

MariusVanDerWijden reviewed Jul 7, 2025

View reviewed changes

shantichanal added 3 commits July 7, 2025 15:21

simplified proof builder structure

6b876c7

adding testing and refining functions

2865b06

refactored and updated e2store framing for objects

a0fffe1

lightclient reviewed Jul 9, 2025

View reviewed changes

Updated with all comments.

6618a4e

Fixed all issues including extra logic regarding proof types, modularizing some functions and refactoring code for correctness and readability.

lightclient self-assigned this Jul 10, 2025

Implemented the proof interface, refactored code, and implemented com…

19ae280

…ments

MariusVanDerWijden reviewed Jul 14, 2025

View reviewed changes

formatting changes and lint

7837839

	// Copyright 2024 The go-ethereum Authors
	// Copyright 2025 The go-ethereum Authors

	compcount uint64 // number of properties
	components uint64 // number of properties

	filelen int64 // length of the file in bytes
	length int64 // length of the file in bytes


		func (*BlockProofHistoricalSummariesDeneb) Variant() proofvar { return proofDeneb }

		func proofVariantOf(p Proof) proofvar {

	func proofVariantOf(p Proof) proofvar {
	func variantOf(p Proof) proofvar {

Draft: New EraE implementation #32157

Are you sure you want to change the base?

Draft: New EraE implementation #32157

Conversation

shazam8253 commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MariusVanDerWijden left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lightclient left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lightclient commented Jul 9, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shazam8253 commented Jul 7, 2025 •

edited

Loading