core/filtermaps: fix log indexer init conditions #31455
Conversation
…exed mode if init fails
|
I am currently testing this PR with #31414 based on top of it and syncing a new pruned sepolia node. The indexer is expected to start indexing from the checkpoint after snap sync is finished. After that I will try to reindex it with the checkpoints removed, in which case the indexer is expected to revert to unindexed mode. |
zsfelfoldi
changed the title
|
The sync finished without any issues, workload test also worked fine (with long range queries restricted to the indexed region). |
|
Also ran the workload test against the indexer disabled node, reverting works fine too (short range tests pass fine, long range tests time out). |
This PR adds an extra condition to the log indexer initialization in order to avoid initializing with block 0 as target head. Previously this caused the indexer to initialize without a checkpoint. Later, when the real chain head was set, it indexed the entire history, then unindexed most of it if only the recent history was supposed to be indexed. Now the init only happens when there is an actual synced chain head and therefore the index is initialized at the most recent checkpoint and only the last year is indexed according to the default parameters. During checkpoint initialization the best available checkpoint is also checked against the history cutoff point and fails if the indexing would have to start from a block older than the cutoff. If initialization fails then the indexer reverts to unindexed mode instead of retrying because the the failure conditions cannot be expected to recover later.
This PR adds an extra condition to the log indexer initialization in order to avoid initializing with block 0 as target head. Previously this caused the indexer to initialize without a checkpoint. Later, when the real chain head was set, it indexed the entire history, then unindexed most of it if only the recent history was supposed to be indexed. Now the init only happens when there is an actual synced chain head and therefore the index is initialized at the most recent checkpoint and only the last year is indexed according to the default parameters.
During checkpoint initialization the best available checkpoint is also checked against the history cutoff point and fails if the indexing would have to start from a block older than the cutoff. If initialization fails then the indexer reverts to unindexed mode instead of retrying because the the failure conditions cannot be expected to recover later.