Skip to content

Conversation

LouisTsai-Csie
Copy link
Collaborator

@LouisTsai-Csie LouisTsai-Csie commented Sep 15, 2025

πŸ—’οΈ Description

Add invalid precompile input cases for p256verify precompile, it is one of the Nethermind gas-benchmarks cases.

πŸ”— Related Issues or PRs

Issue #2026

βœ… Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

@LouisTsai-Csie LouisTsai-Csie self-assigned this Sep 15, 2025
@LouisTsai-Csie LouisTsai-Csie added feature:benchmark fork:osaka Osaka hardfork scope:tests Scope: Changes EL client test cases in `./tests` labels Sep 15, 2025
@LouisTsai-Csie
Copy link
Collaborator Author

A low hanging fruit for us to close issue #2026

Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! I left a comment about making the strings available via the spec file, but feel free to take or leave it :)

pytest.param(
p256verify_spec.Spec.P256VERIFY,
[
"235060CAFE19A407880C272BC3E73600E3A12294F56143ED61929C2FF4525ABB",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're now using these across test files, I wonder if we should assign them values within the Spec file and use them both here and in the test_p256verify.py. For example: Spec.H0_reversed or something?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea, but we are going to have a folder restructuring recently, i prefer to do it after that, and we could also update for different precompiles!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:benchmark fork:osaka Osaka hardfork scope:tests Scope: Changes EL client test cases in `./tests`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants