Add smart contract quiz fixes #13776 #14162
Conversation
CryptoDelirium
requested review from
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
github-actions
bot
added
content 🖋️
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hey @TC1211 / @Qwerky7835, the smart contract quiz is working as expected on the quizzes page, but it is not functioning properly on the smart contracts page. See the screenshot below to see how the quiz appears on the page, or you can view how the quiz appears in the deploy preview link (https://deploy-preview-14162--ethereumorg.netlify.app) provided by the Netlify bot.
To fix this, refer to the suggestion provided here: #13704 (comment). Additionally, reference the issue number in the PR description you are referring to. |
|
Fixed the quiz widget on the smart contract page. |
konopkja
added
needs dev approval 🧑💻
|
This issue is stale because it has been open 30 days with no activity. |
github-actions
bot
added
the
Status: Stale
github-actions
bot
added
tooling 🔧
There was a problem hiding this comment.
Solid work everyone! Thanks to @Qwerky7835 @CryptoDelirium @Shiva-Sai-ssb @JanetMo for helping with this... Apologies for delays so far.
Left a round of comments which I think will take this over the line. @CryptoDelirium would you be capable/interested in making some updates?
| "defi-5-d-explanation": "This is incorrect. DeFi apps don’t need traditional financial institutions. They use blockchain programs called smart contracts to handle transactions automatically." | ||
| "defi-5-d-explanation": "This is incorrect. DeFi apps don’t need traditional financial institutions. They use blockchain programs called smart contracts to handle transactions automatically.", | ||
| "smart-contracts-1-prompt": "How are smart contracts characterized?", | ||
| "smart-contracts-1-a-label": "Smart contracts are just like real (paper) contracts, but stored digitally on the blockchain to save the content securely.", |
There was a problem hiding this comment.
Consider:
| "smart-contracts-1-a-label": "Smart contracts are just like real (paper) contracts, but stored digitally on the blockchain to save the content securely.", | |
| "smart-contracts-1-a-label": "Legal contracts, stored securely on the blockchain", |
There was a problem hiding this comment.
There is no legal weight behind smart contracts right? Maybe just stick to "digital contracts"?
There was a problem hiding this comment.
There is no legal weight by default, correct. This is a suggestion for an incorrect answer choice though, not the correct answer.
| "smart-contracts-1-a-explanation": "Smart contracts use a similar logic to traditional contracts, but otherwise have little in common.", | ||
| "smart-contracts-1-b-label": "They are linked to an AI system, which allows them to make decisions that trigger blockchain transactions.", | ||
| "smart-contracts-1-b-explanation": "Smart contracts can actually execute transactions automatically, but only according to an ‘if this then that’ logic that is prescribed in the code. They do not use AI.", | ||
| "smart-contracts-1-c-label": "They are programs stored on the blockchain that follow an 'if this then that' logic, and are guaranteed to execute according to the rules defined by the code.", |
There was a problem hiding this comment.
Consider:
| "smart-contracts-1-c-label": "They are programs stored on the blockchain that follow an 'if this then that' logic, and are guaranteed to execute according to the rules defined by the code.", | |
| "smart-contracts-1-c-label": "Onchain programs following 'if-this-then-that' logic, guaranteed to execute according to its own rules", |
...although that still feels a touch long.
|
@wackerow Thanks for reviewing. From my side, feel free to implement the suggestions, sounds very good. |
github-actions
bot
removed
the
Status: Stale
Co-authored-by: Paul Wackerow <[email protected]>
Co-authored-by: Paul Wackerow <[email protected]>
Co-authored-by: Paul Wackerow <[email protected]>
Co-authored-by: Paul Wackerow <[email protected]>
Co-authored-by: Paul Wackerow <[email protected]>
Apply review changes Co-authored-by: Paul Wackerow <[email protected]>
Accidentally closed previous PR #13981. References issue #13776.
Quiz content added. Linked quiz to global counter
In collab with @JanetMo