Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sub_idx field to SdoEntryInfo #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add sub_idx field to SdoEntryInfo #2

wants to merge 1 commit into from

Conversation

flosse
Copy link
Contributor

@flosse flosse commented Nov 26, 2020

In some contexts I'd like to know the SubIdx of an entry, so I think it's appropriate to add this field.
What do you think?

BTW: This is a breaking change.

@flosse flosse requested a review from birkenfeld November 26, 2020 14:45
birkenfeld
birkenfeld reviewed Nov 26, 2020
View reviewed changes
Copy link
Member

@birkenfeld birkenfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea about this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birkenfeld birkenfeld birkenfeld left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flosse @birkenfeld