Bump brace-expansion and DOMPurify out of the open advisories - #189
Conversation
Two transitive copies were on affected versions – 2.1.0 and 5.0.5, both reachable only through the build toolchain (@nextcloud/vite-config). The lockfile now pins 2.1.4 and 5.0.9. Lockfile only: nothing in package.json changes, and the built bundle in js/ is byte-identical after a clean npm ci and rebuild. The remaining low advisory, elliptic 6.6.1, has no patched release. It comes in through vite-plugin-node-polyfills inside @nextcloud/vite-config, is a build-time dependency like the above, and cannot be resolved from here.
3.4.12 is covered by the advisory about the IN_PLACE hook leaving a detached subtree behind. Unlike the other open advisories, DOMPurify is a runtime dependency: it sanitizes the snapshot HTML in the browser before the viewer renders it. js/ is rebuilt, so the sanitize-html chunk changes name and content and the two entry bundles follow the new import.
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
PR Summary by QodoBump DOMPurify to 3.4.13 and refresh built sanitize-html bundle
AI Description
Diagram
High-Level Assessment
Files changed (6)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTo customize comments, go to the Qodo configuration screen, or learn more in the docs. |
Two dependency bumps, one commit each.
brace-expansion 2.1.0 → 2.1.4 and 5.0.5 → 5.0.9, lockfile only. Both copies are transitive through
@nextcloud/vite-config, so they run at build time on our own globs, never on user input. Clears the two high advisories.DOMPurify 3.4.12 → 3.4.13, which closes the
IN_PLACEadvisory. This one is a runtime dependency – it sanitizes the snapshot HTML in the browser before the viewer renders it – sojs/is rebuilt in the same commit: thesanitize-htmlchunk changes name and content, and the two entry bundles follow the new import. Nothing else in the bundles moves.This supersedes #185, which carries the same DOMPurify bump but cannot rebuild
js/– that is why itsnpm build + vitestcheck fails against the built-assets guard innode.yml.elliptic(low) stays open: no patched release, and it too only comes in through the build chain.Verified: clean
rm -rf node_modules && npm ci, after whichnpm auditreports only the remainingellipticentries.npm run buildgreen withjs/matching,npm test148/148.