Add an Italian locale, and spell two error headings one way - #188
Merged
Conversation
"Could not open pad" and "Could not create pad" each existed twice, once with a trailing full stop and once without, because the embed page uses them as headings and the controllers as messages. Two keys, one sentence, and a translator had to write both. Settled on the form without the stop, which reads as either. The messages that name what failed stay as they are. Which step could not find a file is not information a user can act on, but which action failed is — that distinction is the reason for the wording, so it keeps its own strings. 180 → 178 keys in de, es and fr.
Italian joins de, es and fr as a maintained locale, with the same 178 keys as the other catalogs, written and reviewed by a native speaker with a working knowledge of the app. Three terms were settled across the whole catalog: "nome dell'host" for hostname, "parent domain" left untranslated, and the app's own picker tiles called "modelli propri dell'app" – Nextcloud's own Italian Files strings call everything in that picker a "modello" and have no word for a tile.
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
PR Summary by QodoAdd Italian locale and consolidate pad open/create error translation keys
AI Description
Diagram
High-Level Assessment
Files changed (18)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTo customize comments, go to the Qodo configuration screen, or learn more in the docs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two catalog changes, one commit each.
Spell the two error headings one way.
Could not open padandCould not create padeach existed twice, once with a trailing full stop and once without – the embed page uses them as headings, the controllers as messages. Two keys for one sentence, and every translator had to write both. Settled on the form without the stop, which reads as either. 180 → 178 keys inde,esandfr.The messages that name what failed stay as they are. Which step could not find a file is not something a user can act on, but which action failed is – that distinction is the reason for the separate wordings.
Add an Italian locale.
itjoinsde,esandfrwith the same 178 keys, written and reviewed by a native speaker with a working knowledge of the app.Verified:
it.jsonandit.jscharacter-for-character identical, key set identical tode, placeholder parity ({domain},{url},{{date}}, …) checked against the source string in all 178 entries, no empty values, plural formnplurals=2; plural=(n != 1);.npm run buildgreen,npm test148/148.No behaviour change – catalogs and one doc file only.