Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation/integrations: add PHP v3 client #9467

Merged
merged 1 commit into from
Jul 6, 2018
Merged

Conversation

ouqiang
Copy link
Contributor

@ouqiang ouqiang commented Mar 20, 2018

Contributing guidelines

Please read our contribution workflow before submitting a pull request.

Copy link
Contributor

@hexfusion hexfusion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ouqiang can you add that the client uses gRPC gateway please. Thanks!

@ouqiang
Copy link
Contributor Author

ouqiang commented Mar 20, 2018

ok

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@d2bbedf). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9467   +/-   ##
=========================================
  Coverage          ?   72.15%           
=========================================
  Files             ?      364           
  Lines             ?    30890           
  Branches          ?        0           
=========================================
  Hits              ?    22289           
  Misses            ?     6969           
  Partials          ?     1632

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2bbedf...215412e. Read the comment docs.

@hexfusion
Copy link
Contributor

@ouqiang kind ping, if you can update commit and rebase I will get this merged. Thanks!

@ouqiang
Copy link
Contributor Author

ouqiang commented Apr 21, 2018

Sorry, I can't currently provide a client using a gRPC gateway, I think using HTTP is more suitable for PHP

@hexfusion
Copy link
Contributor

Sorry, I can't currently provide a client using a gRPC gateway, I think using HTTP is more suitable for PHP

@ouqiang your solution uses the v3 HTTP API which is exposed by the gRPC gateway. So all that I need is for you to change your commit from

[ouqiang/etcd-php](https://github.com/ouqiang/etcd-php) - Client for v3

to

[ouqiang/etcd-php](https://github.com/ouqiang/etcd-php) - Client for v3 gRPC gateway

So that people can understand this.

Thanks!

@gyuho gyuho merged commit f7b3017 into etcd-io:master Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants