Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] backport: tools: add mixed read-write performance evaluation scripts #19275

Merged

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Jan 26, 2025

The tools/rw-heatmaps benchmarking script for the release-3.5 branch requires the txn-mixed command from tools/benchmark to run:

QPS=$(${ETCD_BM_BIN} txn-mixed "" \

This pull request backports tools/benchmark/cmd/txn_mixed.go from commit 79b2777, pull request #13038.

Required for the 3.6 release benchmarks against 3.5.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Backport tools/benchmark/cmd/txn_mixed.go from commit
79b2777, pull request etcd-io#13038.

Co-authored-by: Ivan Valdes <[email protected]>
Signed-off-by: Ivan Valdes <[email protected]>
@ivanvc
Copy link
Member Author

ivanvc commented Jan 26, 2025

/retest

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ivanvc

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz jmhbnz merged commit de0fb18 into etcd-io:release-3.5 Jan 27, 2025
25 checks passed
@jmhbnz
Copy link
Member

jmhbnz commented Jan 27, 2025

Please also update CHANGELOG 🙏🏻

@ivanvc ivanvc deleted the backport-tools-benchmark-txn-mixed branch January 27, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants