[3.5] add experimental-snapshot-catchup-entries flag #17808
Conversation
|
Skipping CI for Draft Pull Request. |
Signed-off-by: Siyuan Zhang <[email protected]>
siyuanfoundation
force-pushed
the
3.5-downgrade-test
branch
from
d544ae4 to
7a8d28e
Compare
|
/retest |
siyuanfoundation
force-pushed
the
3.5-downgrade-test
branch
from
7a8d28e to
2fa2272
Compare
| @@ -302,6 +302,7 @@ func newConfig() *config { | |||
| fs.BoolVar(&cfg.ec.ExperimentalMemoryMlock, "experimental-memory-mlock", cfg.ec.ExperimentalMemoryMlock, "Enable to enforce etcd pages (in particular bbolt) to stay in RAM.") | |||
| fs.BoolVar(&cfg.ec.ExperimentalTxnModeWriteWithSharedBuffer, "experimental-txn-mode-write-with-shared-buffer", true, "Enable the write transaction to use a shared buffer in its readonly check operations.") | |||
| fs.UintVar(&cfg.ec.ExperimentalBootstrapDefragThresholdMegabytes, "experimental-bootstrap-defrag-threshold-megabytes", 0, "Enable the defrag during etcd server bootstrap on condition that it will free at least the provided threshold of disk space. Needs to be set to non-zero value to take effect.") | |||
| fs.Uint64Var(&cfg.ec.SnapshotCatchUpEntries, "experimental-snapshot-catchup-entries", cfg.ec.SnapshotCatchUpEntries, "(WARNING: Use this flag with caution!) Number of entries for a slow follower to catch up after compacting the raft storage entries.") | |||
There was a problem hiding this comment.
I think we should add similar "WARNING: Use this flag with caution!" for the main branch as well.
There was a problem hiding this comment.
Can you provide more context why you think that? The original PR added the warning because we are backporting a feature just for testing, and we didn't want to make it visible to users.
There was a problem hiding this comment.
The original PR added the warning because we are backporting a feature just for testing
I don't think it's a good idea to add a user-facing flag but only supposed to be used by test. #17808 (comment)
There was a problem hiding this comment.
This is only a test only backport, but the original flag was introduced in #15033 with broader set of motivations. I'm mentioning it to ensure we discuss it before we add the warning on the main branch.
|
Please signoff the commit |
siyuanfoundation
force-pushed
the
3.5-downgrade-test
branch
from
9047d40 to
3b4f255
Compare
Signed-off-by: Siyuan Zhang <[email protected]>
siyuanfoundation
force-pushed
the
3.5-downgrade-test
branch
from
3b4f255 to
c391d69
Compare
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
#17752
This is import prerequisite to verify that in a mixed version cluster, the follower receives a snapshot that has the correct schema for that version.
Did not add the flag to help file so that it is a hidden flag that only is used for testing.