build(deps): bump actions/download-artifact from 3 to 4 #17743
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v3...v4) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #17743 +/- ##
==========================================
- Coverage 69.07% 68.95% -0.12%
==========================================
Files 415 415
Lines 34986 34986
==========================================
- Hits 24166 24126 -40
- Misses 9436 9468 +32
- Partials 1384 1392 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
This dependency bump (along with #17744) has a breaking change. Reference to:
I think we need to set |
There was a problem hiding this comment.
@jmhbnz, from what I've seen, dependencies out of the
go.modscope are also out of the scope for the weekly dependency management. Is it okay if I take this GitHub action dependency update? (or maybe @ahrtr, as I see you thumbed-up my comment).
This is a good catch on the breaking change @ivanvc. Agree let's not merge these dependabot pr's and raise one pr manually that bumps both upload and download actions at the same time updating config as required.
Please feel free to raise the pr or open an issue for it @ivanvc 🙏🏻
Will mark the two dependabot pr's as request changes so we don't merge in the interim.
|
@jmhbnz, after reading the documentation and testing it on my fork, I can confirm that we don't need to make any changes. My only suggestion is to use the same format to reference the image with the commit SHA as we do with other action references. Edit: We may want to update both in the same commit, as the documentation says neither is backward compatible. |
|
Looks like actions/download-artifact is up-to-date now, so this is no longer needed. |
dependabot
bot
deleted the
dependabot/github_actions/actions/download-artifact-4
branch
Bumps actions/download-artifact from 3 to 4.
Release notes
Sourced from actions/download-artifact's releases.
Commits
c850b93Merge pull request #307 from bethanyj28/main6fd111fupdate@actions/artifact87c5514Merge pull request #303 from bethanyj28/main47f9ce6update@actions/artifact127824dMerge pull request #299 from bethanyj28/main6dd49bflicensed only artifactf71c0e3Revert "licensed"7c63dfdlicensed67d37cdUpdate toolkit3487549Update release-new-action-version.yml (#292)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)