Skip to content

[ELITERT-1198] Add action to run Ruby linters #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

sergio-bobillier
Copy link
Collaborator

@sergio-bobillier sergio-bobillier commented Oct 31, 2024

The action runs Rubocop and Reek on Pull Requests.

  • The action doesn't fail when there are linter warnings it only adds comments to the files in the Pull Request.

  • To reduce the time needed to install gems the gems needed for linting are being moved to a group and the BUNDLE_ONLY environment variable is being used to install only those.

  • To prevent Rubocop from scanning the vendor directory an exclusion entry is being added to its configuration file.

@sergio-bobillier sergio-bobillier force-pushed the sb-linters-action branch 27 times, most recently from 35b3d4a to caae4ce Compare October 31, 2024 17:00
The action runs Rubocop and Reek on Pull Requests.

* The action doesn't fail when there are linter warnings it only adds
  comments to the files in the Pull Request.

* To reduce the time needed to install gems the gems needed for linting
  are being moved to a group and the BUNDLE_ONLY environment variable
  is being used to install only those.

* To prevent Rubocop from scanning the 'vendor' directory an exclusion
  entry is being added to its configuration file.
@sergio-bobillier sergio-bobillier merged commit a983c2c into master Nov 4, 2024
2 checks passed
@sergio-bobillier sergio-bobillier deleted the sb-linters-action branch November 4, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants