Fixes on TCP source and producer loop #2226
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The real number of added bytes is what get copied into buffer, not the bytes count we get from the socket.
Count incomplete errors and skip bytes if they produced multiple times in raw to avoid filling the internal buffers without being able to parse the data or skip it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is work in progress.
TCP Source:
Tcp source should return the count of copied bytes into buffer, because that's the count what get copied into buffer, not the bytes count we get from the socket.
Producer Loop:
Count incomplete errors and skip bytes if they produced multiple times in raw to avoid filling the internal buffers without being able to parse the data or skip it