Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to plugins manager and Backend APIs #2225

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Changes to plugins manager and Backend APIs #2225

merged 1 commit into from
Feb 14, 2025

Conversation

AmmarAbouZor
Copy link
Member

This PR closes #2207

It introduces the following changes:

  • Separate installed and invalid plugins with separated types and list on plugins manager.
  • Change API enabling requesting for installed or invalid plugins with all their infos or with the directory paths only (considered is ID), Additionally I've created two APIs to get the information of a plugin which path is provided.
  • Refactoring for loading the plugins in plugin manager to reduce code duplication.
  • Changes in plugin types with their corresponding protocol functions and proptests

@AmmarAbouZor
Plugins Manager: Changes in types & loading.
196c41a 
* Different types for valid and invalid plugins instead of using the
  same time with various states.
* Plugin manager provides different APIs for valid and invalid plugins
  alongside with new function to provide the plugins directories only
  and ones to get one plugin info based on the provided plugin directory
* Change loading internal function to use one function for both plugin
  types, reducing duplicated code.
* Extend proptests and type generation code.

* Provide more APIs for get plugins in both states with full info and
  with paths only + APIs to get infos to one plugin based on the giving
  plugin directory.
* Rename active plugins to installed plugins.
* Adjustments in protocol, bindings and tests in ts-bindings

* Adjustments for API calls in platform, client and holder.

* Plugins Manager: Added unit tests
@AmmarAbouZor AmmarAbouZor marked this pull request as ready for review February 14, 2025 08:31
@AmmarAbouZor AmmarAbouZor merged commit c02e8a6 into esrlabs:plugins_support Feb 14, 2025
4 checks passed
@AmmarAbouZor AmmarAbouZor deleted the plugins_manager_api branch February 14, 2025 08:49
@AmmarAbouZor AmmarAbouZor mentioned this pull request Feb 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmitryAstafyev DmitryAstafyev DmitryAstafyev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AmmarAbouZor @DmitryAstafyev