-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New app: tev's timer #3868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
New app: tev's timer #3868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix breakage such as alarm reloading nonstop when a timer triggers
Avoid conflicts with alarm snoozing, etc.
1. Make snoozing only available for non-chained timers (or the last timer in a chain) 2. Don't let dismissing a snoozed timer restart the chained timer if it was paused (though 1. should preclude this from happening anyway)
Going to TimerEditMenu directly from a quick action and then entering Name or Start causes TimerEditMenu's back button not to go straight back to TimerView because TimerEditMenu's overridden back action gets lost. Solve this by making Name and Start's back actions return to the existing instance of TimerEditMenu rather than creating a new one.
…hey are reloaded properly)
Sounds good, do you have this deployed anywhere to test it out? (you can deploy it with these instructions) |
You can find it here: https://ticalc-travis.github.io/BangleApps/?id=tevtimer I've been using it as my daily timer app on my Bange.js 2 for a while. |
Great! Very thorough and extensive app, fits in nicely with the scheduler stuff like you mentioned in the discussion - thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's my new advanced timer app with interval/repeats, configurability, etc., discussed at https://github.com/orgs/espruino/discussions/7754