Skip to content

fix(ncm): wNdbInDivisor/wNdbOutDivisor rejected as 1 by Windows KB5124008 #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tore-espressif merged 2 commits into from
Sep 16, 2026
Merged

fix(ncm): wNdbInDivisor/wNdbOutDivisor rejected as 1 by Windows KB5124008 #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7635e2f
fix(ncm): bump wNdbInDivisor/wNdbOutDivisor from 1 to 4 for Windows c…
Warumski Sep 13, 2026
5d5445a
change: Add 0.21.0~2 release note
tore-espressif Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ Only Device part of TinyUSB stack is supported. For Host mode, please refer to [
| Upstream tag | Fork tag | IDF component | Diff |
| :--- | :--- | :--- | :--- |
| [`0.21.0`](https://github.com/hathach/tinyusb/releases/tag/0.21.0) | [`v0.21.0.1`](https://github.com/espressif/tinyusb/releases/tag/v0.21.0.1) | `0.21.0~1` | [compare](https://github.com/espressif/tinyusb/compare/hathach:tinyusb:0.21.0...v0.21.0.1) |
| [`0.21.0`](https://github.com/hathach/tinyusb/releases/tag/0.21.0) | [`v0.21.0.2`](https://github.com/espressif/tinyusb/releases/tag/v0.21.0.2) | `0.21.0~2` | [compare](https://github.com/espressif/tinyusb/compare/hathach:tinyusb:0.21.0...v0.21.0.2) |

TinyUSB has not yet reached its first stable release (v1.0.0), so breaking changes may still occur in any version. In practice, the API remains relatively stable, and when incompatible changes arise, we aim to preserve backward compatibility where feasible.

Expand Down
11 changes: 9 additions & 2 deletions src/class/net/ncm_device.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,16 +166,23 @@ TU_ATTR_WEAK bool tud_network_default_link_state_cb(void) {
* \attention
* We are lucky, that byte order is correct
*/

// wNdbInDivisor/wNdbOutDivisor: a Windows Update (KB5124008, Sept 2026)
// enabled NTB-parameter validation in usbncm.sys requiring these to be
// >=4 and a power of 2. 1 is spec-legal but now rejected with
// STATUS_DEVICE_HARDWARE_ERROR (Code 10) during enumeration. 4 satisfies
// the check and is spec-legal on the device side too.

TU_ATTR_ALIGNED(4) static const ntb_parameters_t ntb_parameters = {
.wLength = sizeof(ntb_parameters_t),
.bmNtbFormatsSupported = 0x01,// 16-bit NTB supported
.dwNtbInMaxSize = CFG_TUD_NCM_IN_NTB_MAX_SIZE,
.wNdbInDivisor = 1,
.wNdbInDivisor = 4,
.wNdbInPayloadRemainder = 0,
.wNdbInAlignment = TUD_NCM_ALIGNMENT,
.wReserved = 0,
.dwNtbOutMaxSize = CFG_TUD_NCM_OUT_NTB_MAX_SIZE,
.wNdbOutDivisor = 1,
.wNdbOutDivisor = 4,
.wNdbOutPayloadRemainder = 0,
.wNdbOutAlignment = TUD_NCM_ALIGNMENT,
.wNtbOutMaxDatagrams = CFG_TUD_NCM_OUT_MAX_DATAGRAMS_PER_NTB,
Expand Down
Loading