Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 4816623

Browse files
committedFeb 27, 2024
Update Action scripts to save build on failure
1 parent d6638b2 commit 4816623

File tree

3 files changed

+18
-6
lines changed

3 files changed

+18
-6
lines changed
 

‎.github/workflows/cron.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,14 @@ jobs:
4141
run: |
4242
git checkout ${{ matrix.idf_branch }} || echo "Using master branch"
4343
bash ./tools/cron.sh
44+
- name: Upload build
45+
if: failure()
46+
uses: actions/upload-artifact@v4
47+
with:
48+
name: build
49+
path: build
4450
- name: Upload archive
45-
uses: actions/upload-artifact@v3
51+
uses: actions/upload-artifact@v4
4652
with:
4753
name: artifacts
4854
path: dist

‎.github/workflows/push.yml

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,14 @@ jobs:
2525
run: bash ./tools/prepare-ci.sh
2626
- name: Build Libs for ${{ matrix.target }}
2727
run: bash ./build.sh -e -t ${{ matrix.target }}
28+
- name: Upload build
29+
if: failure()
30+
uses: actions/upload-artifact@v4
31+
with:
32+
name: build
33+
path: build
2834
- name: Upload archive
29-
uses: actions/upload-artifact@v3
35+
uses: actions/upload-artifact@v4
3036
with:
3137
name: artifacts
3238
path: dist
@@ -48,12 +54,12 @@ jobs:
4854
cd out/tools/esp32-arduino-libs && tar zcf ../../../dist/esp32-arduino-libs.tar.gz * && cd ../../..
4955
cp out/package_esp32_index.template.json dist/package_esp32_index.template.json
5056
- name: Upload full esp32-arduino-libs archive
51-
uses: actions/upload-artifact@v3
57+
uses: actions/upload-artifact@v4
5258
with:
5359
name: esp32-arduino-libs
5460
path: dist/esp32-arduino-libs.tar.gz
5561
- name: Upload package_esp32_index.template.json
56-
uses: actions/upload-artifact@v3
62+
uses: actions/upload-artifact@v4
5763
with:
5864
name: package-esp32-index-json
5965
path: dist/package_esp32_index.template.json

‎.github/workflows/repository_dispatch.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@ jobs:
1818
run: bash ./tools/repository_dispatch.sh
1919
- name: Upload build
2020
if: failure()
21-
uses: actions/upload-artifact@v3
21+
uses: actions/upload-artifact@v4
2222
with:
2323
name: build
2424
path: build
2525
- name: Upload archive
26-
uses: actions/upload-artifact@v3
26+
uses: actions/upload-artifact@v4
2727
with:
2828
name: artifacts
2929
path: dist

2 commit comments

Comments
 (2)

Jason2866 commented on Feb 27, 2024

@Jason2866
Contributor

@me-no-dev The change from artifact action from v3 to v4 has breaking changes. Had fun too.
See https://github.com/actions/upload-artifact?tab=readme-ov-file#not-uploading-to-the-same-artifact

I forked and updated the deprecated node js stuff.

me-no-dev commented on Feb 27, 2024

@me-no-dev
MemberAuthor

yup, I was looking into that. Updated the scripts in the latest commit, though currently fighting another strange error (lib-builder failing in CI, but nowhere else and also not failing on S2)

Please sign in to comment.