Skip to content

Update tinyuf2 0.35 #11631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

tyeth
Copy link
Contributor

@tyeth tyeth commented Jul 23, 2025

Description of Change

Updates the bootloader and tinyuf2 app bin files for the Adafruit boards.

Also fixes the csv name for the XIAO S3 tinyuf2 partition. It's got a partitions-8mb.csv but instead refers to a partitions-8mb-tinuf2.csv which is one of the tinyuf2 partition files that were renamed ages ago.
As the board appeared to be pointing to a non existent file, rather than point at the one in board folder this switches to the communal CSV (same content) and adds the 8MB No OTA partition scheme. Did the tinyuf2 bins for those xiao s3's too, did both after verifying same content between them.

Tests scenarios

Please describe on what Hardware and Software combinations you have tested this Pull Request and how.
Grabbed latest release zips from tinyuf2, as our CI has been, built with the bootloader and tinyuf2 files updated (plus boot_app0.bin), tested normal and tinyuf2 functionality.

Tested both tinyuf2 partitions for XIAO S3 in arduino ide blink example with updated boards.txt, then checked partition scheme correctly written, and tinyuf2 bootloader still works as expected (well half 😂 I was expecting double tap reset, but it's reset then tap boot button to enter tinyuf2 bootloader mode on XIAO S3).

@tyeth tyeth requested a review from P-R-O-C-H-Y as a code owner July 23, 2025 17:58
@CLAassistant
Copy link

CLAassistant commented Jul 23, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Jul 23, 2025

Fails
🚫

node failed.

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Merge branch 'master' into update-tinyuf2-0.35":
    • probably contains Jira ticket reference (2-0). Please remove Jira tickets from commit messages.
  • the commit message "Switch XIAO_ESP32S3 from tinyuf2 custom_partitions to shared partitions csvs":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update Adafruit boards to tinyuf2 0.35.0":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update XIAO S3 to tinyuf2 0.35.0, add no-OTA, use shared tinyuf2 partition csv":
    • summary looks empty
    • type/action looks empty
  • the commit message "add new version of sparklemotion":
    • summary looks empty
    • type/action looks empty
  • the commit message "fix clang complaints":
    • summary looks empty
    • type/action looks empty
  • the commit message "fix":
    • summary looks empty
    • type/action looks empty
  • the commit message "updated change as requested":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

Log

┌─────────┬─────────────────────────────────────┬───────────────────────────────────────────────────────┬─────────────────────────────┐
│ (index) │             CiVariable              │                         Value                         │       CustomSettings        │
├─────────┼─────────────────────────────────────┼───────────────────────────────────────────────────────┼─────────────────────────────┤
│    0    │  'ENABLE_RULE_PR_COMMIT_MESSAGES'   │                         true                          │          'default'          │
│    1    │    'ENABLE_RULE_PR_DESCRIPTION'     │                         true                          │          'default'          │
│    2    │     'ENABLE_RULE_PR_SIZE_LINES'     │                         true                          │          'default'          │
│    3    │ 'ENABLE_RULE_PR_SOURCE_BRANCH_NAME' │                         true                          │          'default'          │
│    4    │   'ENABLE_RULE_PR_TARGET_BRANCH'    │                         false                         │ 'custom (default is: true)' │
│    5    │  'ENABLE_RULE_PR_TOO_MANY_COMMITS'  │                         false                         │ 'custom (default is: true)' │
│    6    │    'ENABLE_OUTPUT_INSTRUCTIONS'     │                         true                          │          'default'          │
│    7    │             'CLA_LINK'              │  'https://cla-assistant.io/espressif/arduino-esp32'   │   'custom (default is: )'   │
│    8    │   'COMMIT_MESSAGE_ALLOWED_TYPES'    │ 'change,ci,docs,feat,fix,refactor,remove,revert,test' │          'default'          │
│    9    │      'CONTRIBUTING_GUIDE_FILE'      │              'docs/en/contributing.rst'               │   'custom (default is: )'   │
│   10    │   'IGNORED_SECTIONS_DESCRIPTION'    │              'related,release,breaking'               │          'default'          │
│   11    │         'IS_GITLAB_MIRROR'          │                         false                         │          'default'          │
│   12    │   'MAX_COMMIT_MESSAGE_BODY_LINE'    │                          100                          │          'default'          │
│   13    │    'MAX_COMMIT_MESSAGE_SUMMARY'     │                          72                           │          'default'          │
│   14    │         'MAX_COMMITS_WARN'          │                           5                           │          'default'          │
│   15    │            'MAX_COMMITS'            │                           2                           │          'default'          │
│   16    │           'MAX_PR_LINES'            │                         1000                          │          'default'          │
│   17    │    'MIN_COMMIT_MESSAGE_SUMMARY'     │                          10                           │  'custom (default is: 20)'  │
│   18    │     'MIN_PR_DESCRIPTION_LENGTH'     │                          50                           │          'default'          │
└─────────┴─────────────────────────────────────┴───────────────────────────────────────────────────────┴─────────────────────────────┘
DangerJS checks (rules) output states:
======================================================================================================
Commit messages style......................................................................... �[31mFailed�[0m
Pull Request size (number of changed lines)................................................... �[32mPassed�[0m
Pull Request sufficient Description........................................................... �[32mPassed�[0m
Source branch name............................................................................ �[32mPassed�[0m
======================================================================================================
Error:  RequestError [HttpError]: API rate limit exceeded for 52.190.141.34. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)
    at /node_modules/@octokit/request/dist-node/index.js:86:21
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  status: 403,
  response: {
    url: 'https://api.github.com/repos/espressif/arduino-esp32',
    status: 403,
    headers: {
      'access-control-allow-origin': '*',
      'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-RateLimit-Used, X-RateLimit-Resource, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset',
      connection: 'close',
      'content-length': '279',
      'content-security-policy': "default-src 'none'; style-src 'unsafe-inline'",
      'content-type': 'application/json; charset=utf-8',
      date: 'Wed, 23 Jul 2025 22:04:42 GMT',
      'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
      server: 'Varnish',
      'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
      'x-content-type-options': 'nosniff',
      'x-frame-options': 'deny',
      'x-github-media-type': 'github.v3; format=json',
      'x-github-request-id': 'E401:12B778:4E78037:50E7DD8:68815C79',
      'x-ratelimit-limit': '60',
      'x-ratelimit-remaining': '0',
      'x-ratelimit-reset': '1753311191',
      'x-ratelimit-resource': 'core',
      'x-ratelimit-used': '60',
      'x-xss-protection': '1; mode=block'
    },
    data: {
      message: "API rate limit exceeded for 52.190.141.34. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)",
      documentation_url: 'https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting'
    }
  },
  request: {
    method: 'GET',
    url: 'https://api.github.com/repos/espressif/arduino-esp32',
    headers: {
      accept: 'application/vnd.github.v3+json',
      'user-agent': 'octokit-rest.js/18.12.0 octokit-core.js/3.6.0 Node.js/18.15.0 (linux; x64)'
    },
    request: { hook: [Function: bound bound register] }
  }
}
danger-results://tmp/danger-results-86bb490b.json

Generated by 🚫 dangerJS against 8235fae

@tyeth
Copy link
Contributor Author

tyeth commented Jul 23, 2025

Hey, if we want this partition scheme update in the next release plus in older version releases like 3.1.x and 3.2.x and 3.3.x then what's the correct way to go about it?

@tyeth
Copy link
Contributor Author

tyeth commented Jul 23, 2025

DangerJS failure: Checks are being rate limited at GH, so CI needs kicking

@tyeth tyeth marked this pull request as draft July 23, 2025 21:23
@tyeth
Copy link
Contributor Author

tyeth commented Jul 23, 2025

Drafting this to also add some verbiage updates for the partition schemes.
EDIT: Will do partition label updates in another PR if needed

@tyeth tyeth marked this pull request as ready for review July 23, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants