Normalize similar arguments

[SergioGasquez]

I also removed some short arguments that didnt make much sense to me (I can revert those)

[SergioGasquez]

Shall I also edit the other places of the codebase where we use offset/addr instead of address and so on..?

[SergioGasquez]

Id like to come up with better names for monitoring args:

• MonitorConfigArgs has baudrate which can be set with MONITOR_BAUD environment variable
• ConnectArgs has baud which can be set ESPFLASH_BAUD environment variable

Here is what esptool does: #736

[SergioGasquez]

Id like to come up with better names for monitoring args:

• MonitorConfigArgs has baudrate which can be set with MONITOR_BAUD environment variable
• ConnectArgs has baud which can be set ESPFLASH_BAUD environment variable

Here is what esptool does: #736

For the moment, I'm using baud for ConnectArgs and monitor_baud for MonitorConfigArgs. But open to suggestions here

[JurajSadel]

LGTM

[SergioGasquez]

I removed the requires because it was failing when using it as a custom runner, since you have the elf from the image, but dont have the elf arg.

You still get a pretty decent error when you do espflash monitor --log-format defmt and dont provide and elf:

❯ cargo r -r --bin espflash -- monitor --log-format defmt
...
Commands:
    CTRL+R    Reset chip
    CTRL+C    Exit

Error: espflash::monitor::defmt::no_elf

  × No elf data available
  help: Please provide an ELF file with the `--elf` argument

But you get that after selecting the port

[SergioGasquez]

Maybe we could investigate improving this in #764, since is somewhat similar

[bugadani]

It's also an issue in that espflash flash <image> --elf <image> is meaningless, but it's allowed.

[jessebraham]

Thanks!