Fix waiting for short periods #3093
Open
+117
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
bugadani
force-pushed
the
timer-fix
branch
2 times, most recently
from
e0e7fa7 to
4d17288
Compare
Dominaezzz
reviewed
Feb 5, 2025
| impl Drop for AlarmFuture<'_> { | ||
| fn drop(&mut self) { | ||
| self.alarm.enable_interrupt(false); | ||
| self.alarm.clear_interrupt(); |
There was a problem hiding this comment.
Clearing the interrupt here breaks cancellation I think, you ideally want to be able to re-create this future in the future for the same alarm.
There was a problem hiding this comment.
Ah nvm, I don't think the cancellation semantics where ever decided on the timers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (built on top of #3083) shortens wait times in tests (which trigger this issue), and sets the interrupt enable sooner, and changes code to work with that.