Migrate PARL_IO driver to newer DMA API #3033
Draft
+330
−280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! I wanted to do this for quite some time 👍 |
bugadani
reviewed
Jan 27, 2025
| @@ -1733,73 +1795,51 @@ pub mod asynch { | |||
| cx: &mut core::task::Context<'_>, | |||
| ) -> Poll<Self::Output> { | |||
| TX_WAKER.register(cx.waker()); | |||
There was a problem hiding this comment.
You can move the TX registration to the else branch, just above listen_tx_done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
It's all the title says the driver now uses the newer DMA move APIs.
As a consequence of this and #2587,
EofModeon the RX side is now specified at transfer time instead of construction time.imo, this gives users more flexibility.
Testing
HIL