Remove flip-link feature, replace by flip-link option
#3001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernQ
force-pushed
the
flip-link-option
branch
from
ce3c271 to
c8846a2
Compare
bjoernQ
changed the title
flip-link feature, replace by flip-link option
jessebraham
reviewed
Jan 21, 2025
MabezDev
requested changes
Jan 21, 2025
bjoernQ
force-pushed
the
flip-link-option
branch
from
13ca950 to
fd0cb27
Compare
Dominaezzz
reviewed
Jan 22, 2025
bjoernQ
force-pushed
the
flip-link-option
branch
from
1f4fc91 to
5e6a595
Compare
MabezDev
approved these changes
Jan 23, 2025
Dominaezzz
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
flip-linkfeature, replaced byESP_HAL_CONFIG_FLIP_LINKconfigquad-psramandoctal-psramfeatures - replaced bypsramfeature plusESP_HAL_CONFIG_PSRAM_MODE(quad/octal)Validator::Enumerationvalidator in esp-config (we could use it inesp-hal-embassy, too - but probably in another PR)skip-changelogbecause of non-user-facing changes in some packagescloses #2997
Testing
CI, manual testing