Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp-wifi: Use timer_queue #2952

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Jan 14, 2025

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • I have added necessary changes to user code to the Migration Guide.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

skip-changelog - no user facing change

Draft because it needs more testing. There are some more improvements I'd like to do which would be based on this.

There are some concerns regarding adding that timer-queue dependency.

  • it's not widely used (no dependents on crates.io)
  • two additional dependencies (one transitive but that one is quite popular)
  • we already have a timer-queue in esp-hal-embassy (but that one is very different and specialized - don't see that fit here)

I would like to land this PR someday (since it changes things to the better) - I could replace that crate with our own implementation but not sure it's worth it.

  • that crate doesn't look too bad
  • if we ever need to replace it - wouldn't be too hard to come up with our own implementation (but timer-queue claims to be optimized for the task)

Testing

Running examples

@bjoernQ bjoernQ added the skip-changelog No changelog modification needed label Jan 14, 2025
@bjoernQ bjoernQ changed the title Use timer_queue esp-wifi: Use timer_queue Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant