Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(uart): config option to disable the rx input checks #2756

Closed

Conversation

zpg6
Copy link
Contributor

@zpg6 zpg6 commented Dec 13, 2024

Description

Aims to resolve #1580. Added a configuration to uart::Config for the ability to disabled forced input checks on incoming RX data. This is useful for cases like reading breaks.

Testing

Still to be conducted.

@zpg6
Copy link
Contributor Author

zpg6 commented Dec 13, 2024

Maybe disable_rx_input_checks: bool isn't best naming. Open to suggestions

@bugadani
Copy link
Contributor

I think the naming is fine for now. I don't think this option will end up getting stabilized in the first round, and we'll need to understand what's happening better. But until we get to that point, this may be an okay solution.

@zpg6
Copy link
Contributor Author

zpg6 commented Dec 13, 2024

I think the naming is fine for now. I don't think this option will end up getting stabilized in the first round, and we'll need to understand what's happening better. But until we get to that point, this may be an okay solution.

Let me try it out and see how useful it is in its current form.

@zpg6
Copy link
Contributor Author

zpg6 commented Dec 30, 2024

Closing this in favor of #2858 (which is the correct solution, and works).

@zpg6 zpg6 closed this Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uart: problems after added check of err_wr_mask in config
2 participants