Skip to content

Commit

Permalink
Remove set_priority
Browse files Browse the repository at this point in the history
  • Loading branch information
bugadani committed Feb 3, 2025
1 parent 23dfcf6 commit 40720d1
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 13 deletions.
1 change: 1 addition & 0 deletions esp-hal/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Removed `Pin`, `RtcPin` and `RtcPinWithResistors` implementations from `Flex` (#2938)
- OutputOpenDrain has been removed (#3029)
- The fields of config structs are no longer public (#3011)
- Removed the dysfunctional `DmaChannel::set_priority` function (#3088)

## [0.23.1] - 2025-01-15

Expand Down
9 changes: 0 additions & 9 deletions esp-hal/src/dma/gdma.rs
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,6 @@ impl DmaChannel for AnyGdmaChannel {
type Rx = AnyGdmaRxChannel;
type Tx = AnyGdmaTxChannel;

fn set_priority(&self, priority: DmaPriority) {
AnyGdmaRxChannel(self.0).set_priority(priority);
AnyGdmaTxChannel(self.0).set_priority(priority);
}

unsafe fn split_internal(self, _: crate::private::Internal) -> (Self::Rx, Self::Tx) {
(AnyGdmaRxChannel(self.0), AnyGdmaTxChannel(self.0))
}
Expand Down Expand Up @@ -676,10 +671,6 @@ macro_rules! impl_channel {
type Rx = AnyGdmaRxChannel;
type Tx = AnyGdmaTxChannel;

fn set_priority(&self, priority: DmaPriority) {
AnyGdmaChannel($num).set_priority(priority);
}

unsafe fn split_internal(self, _: $crate::private::Internal) -> (Self::Rx, Self::Tx) {
(AnyGdmaRxChannel($num), AnyGdmaTxChannel($num))
}
Expand Down
4 changes: 0 additions & 4 deletions esp-hal/src/dma/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1618,10 +1618,6 @@ pub trait DmaChannel: Peripheral<P = Self> {
/// A description of the TX half of a DMA Channel.
type Tx: DmaTxChannel;

/// Sets the priority of the DMA channel.
#[cfg(gdma)]
fn set_priority(&self, priority: DmaPriority);

/// Splits the DMA channel into its RX and TX halves.
#[cfg(any(esp32c6, esp32h2, esp32s3))] // TODO relax this to allow splitting on all chips
fn split(self) -> (Self::Rx, Self::Tx) {
Expand Down

0 comments on commit 40720d1

Please sign in to comment.