-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSUE-183: TUS-PHP/JS Uploader for webform files #185
Open
DiegoPino
wants to merge
15
commits into
1.5.0
Choose a base branch
from
ISSUE-183
base: 1.5.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(v2.4 as of today really)
…upload (TBH if the UUID is v4 (random) or seeded with a namespace as a UUIDV5 )
(well the user is in the file entity... but the webform might be useful)
Might also add later here some Tus upload cleanups
TUS @alliomeria just confirming i am slow. But not lazy
The integration is actually quite involved so i need to fix some data before adding all the configs/options and HTML we need.
A lot is right now just fixed to test. I need to pass the actual route to the Tus JS using $url = Url::fromRoute('webform_strawberryfield.tus.upload_complete'); $token = \Drupal::csrfToken()->get($url->getInternalPath()); $url->setOptions(['absolute' => TRUE, 'query' => ['token' => $token]]); $absolute_url = $url->toString() Or, not use csrfToken ....
csrf token seems to be working
But i still need the actual refresh/reload these ones generate But as they are, they are interfering with the TUS...
…S)... that the file module provides though ... might just override the method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
Javascript
Because they got 'includes' a few years ago
UI/UX
The thing people do when in front of a screen
Webform Elements
Things with input to fill and interact with while ingesting metadata
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #183. WIP, means marking as a draft for now