ISSUE-459: Ajax/Facet/Views improvements + ML similarity contextual filter and facets and 10.3 compatibility #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filters the theme and ajax page state from the query, better checking if something is actually there and successfully updated, etc.
DiegoPino
added
enhancement
|
This starts cleaning the Ajax mess. Still missing a fix related to an issue that happens when you have multiple views in a single page, some have pagers and some have facets. A facet will only refresh the View it is attached to via AJAX, but won't wring its arguments to other Views that have pagers, which basically mean, when you page and click on something or filter, the URL itself of the page won't be passed around by the View to the next page, basically making "facet" selections to get stuck in space/time/state or being ignored. The solution is probably, on any View Update triggered by a Facet to also Check other/not to be updated Views and either
@alliomeria that is where I am now |
… driven The idea here is that we also collect for all facets the other views present in the page and if they have pagers we also (not sure yet how) do a "refresh" either partial (reloading the attached behavior for the paging) or complete (easier but also more server intensive?) to make sure the facet selection does not get lost between paging but also the page itself (*current one) is re-used for those views so the view does not fully fully reset . @alliomeria more to come. Not ready yet
Persist session and ajax page state too (breaking also in 10.3, facets actually need to be manually patched or will also break on ajax)
…ents This can be better though
DiegoPino
changed the title
DiegoPino
changed the title
Another commit will also mimic back (update) the hash when people decide to search from 0 or again.
That way navigating between canvases won't break the URL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #459
Also brings some Changes/fixes that happened for Drupal 11
https://git.drupalcode.org/project/drupal/-/commit/ef985e937c58257c4f73f034cfd9b828430f9ad6