Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.0 nov 2022 updates #143

Merged
merged 11 commits into from
Nov 29, 2022
Merged

Conversation

alliomeria
Copy link
Contributor

@alliomeria alliomeria commented Nov 29, 2022

Includes several updates to different AMI-related sections of Archipelago, plus a copy -with credit to @DiegoPino- for his new MetadataInArchipelago.md (plus an updated mkdocs.yml with potential placement in the docs site navigation menu).

Please let me know if all reads well, if any screenshots or new notes need to be edited further. Thank you @DiegoPino & @karomabiles !

@alliomeria alliomeria added the documentation Improvements or additions to documentation label Nov 29, 2022
@alliomeria
Copy link
Contributor Author

alliomeria commented Nov 29, 2022

👀 @karomabiles --the AMIviaSpreadsheets.md contains updated info related to the latest Processing options (steps 7-10 in the doc) that you may want to copy over into the I7 Importer docs updates you have cooking.

Copy link
Member

@DiegoPino DiegoPino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not find anything wrong, not even a typo! Will give @karomabiles a chance to look at this too but this gets my silly seal of approval! Thanks @alliomeria !

@DiegoPino
Copy link
Member

FYI: that merge was a small conflict resolution for the YML file. (in case you wonder).

@alliomeria
Copy link
Contributor Author

Thank you very much for your review + feedback + fix for the YML file conflict @DiegoPino!

@DiegoPino
Copy link
Member

Anytime @alliomeria 🥇

Copy link
Contributor

@karomabiles karomabiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alliomeria Updates look great and explanations/guides flow well! I didn't see any additional changes needed :)

@DiegoPino DiegoPino merged commit 88eed38 into esmero:1.0.0 Nov 29, 2022
@DiegoPino
Copy link
Member

Thanks so much @alliomeria for this documentation work. Very thorough and well written

@alliomeria alliomeria mentioned this pull request Nov 29, 2022
18 tasks
@alliomeria alliomeria linked an issue Nov 29, 2022 that may be closed by this pull request
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation Updates (Macro)
3 participants