Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-61: Remove node_type from drupal configs #62

Merged
merged 3 commits into from
Aug 7, 2022
Merged

ISSUE-61: Remove node_type from drupal configs #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2a0dc3
Update configs to remove all instances of node_type.
Aug 5, 2022
c280d30
Remove configs accidentally copied from archipelago-deployment.
Aug 5, 2022
7ed961c
Missed a few accidentally added configs.
Aug 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions drupal/config/sync/block.block.breadcrumbs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,6 @@ visibility:
bundles:
digital_object: digital_object
digital_object_collection: digital_object_collection
node_type:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait! The replacement is missing here? I see the node_type gone but not new new Conditional?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or am I missing something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DiegoPino Unless I'm misunderstanding, I'm assuming that the 'entity_bundle:node' just above it is the correct one since replacing just as the update hook does would make them identical, but I wanted to check in a deployment just to make sure I'm not missing something.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aksm No worries, I was mistaken. I saw a bunch of lines removed and did not notice the good/new ones were already present. I will merge this

id: node_type
negate: false
context_mapping:
node: '@node.node_route_context:node'
bundles:
digital_object: digital_object
digital_object_collection: digital_object_collection
request_path:
id: request_path
negate: false
Expand Down
7 changes: 0 additions & 7 deletions drupal/config/sync/block.block.views_block__collection_membership_block_1.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,6 @@ visibility:
node: '@node.node_route_context:node'
bundles:
digital_object_collection: digital_object_collection
node_type:
id: node_type
negate: false
context_mapping:
node: '@node.node_route_context:node'
bundles:
digital_object_collection: digital_object_collection
request_path:
id: request_path
negate: true
Expand Down
4 changes: 2 additions & 2 deletions drupal/config/sync/block.block.views_block__collection_membership_block_1_2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ settings:
views_label: ''
items_per_page: none
visibility:
node_type:
id: node_type
'entity_bundle:node':
id: 'entity_bundle:node'
negate: false
context_mapping:
node: '@node.node_route_context:node'
Expand Down
7 changes: 0 additions & 7 deletions drupal/config/sync/block.block.views_block__creative_work_series_children_block_1.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,6 @@ settings:
views_label: ''
items_per_page: none
visibility:
node_type:
id: node_type
negate: false
context_mapping:
node: '@node.node_route_context:node'
bundles:
digital_object_collection: digital_object_collection
'entity_bundle:node':
id: 'entity_bundle:node'
negate: false
Expand Down
7 changes: 0 additions & 7 deletions drupal/config/sync/block.block.views_block__creative_work_series_children_block_1_2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,6 @@ visibility:
node: '@node.node_route_context:node'
bundles:
digital_object_collection: digital_object_collection
node_type:
id: node_type
negate: false
context_mapping:
node: '@node.node_route_context:node'
bundles:
digital_object_collection: digital_object_collection
request_path:
id: request_path
negate: false
Expand Down
8 changes: 0 additions & 8 deletions drupal/config/sync/block.block.views_block__ld_display_for_digital_objects_sql_block_1.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,3 @@ visibility:
negate: true
context_mapping: { }
pages: "/node/*/edit\r\n*/add/*\r\n/search"
node_type:
id: node_type
negate: false
context_mapping:
node: '@node.node_route_context:node'
bundles:
digital_object_collection: digital_object_collection
digital_object: digital_object
2 changes: 1 addition & 1 deletion drupal/config/sync/pathauto.pattern.digital_object_uuid.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ type: 'canonical_entities:node'
pattern: '/do/[node:uuid]'
selection_criteria:
b81bd56a-c753-4756-9aff-a39dacf31da6:
id: node_type
id: 'entity_bundle:node'
negate: false
uuid: b81bd56a-c753-4756-9aff-a39dacf31da6
context_mapping:
Expand Down
2 changes: 1 addition & 1 deletion drupal/config/sync/views.view.data_collection_manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,7 +628,7 @@ display:
multi_type: separator
multi_separator: ', '
display_methods:
node_type:
'entity_bundle:node':
display_method: id
title:
id: title
Expand Down