ISSUE-195: CSV queue worker and nested CSVs for EAD + an EAD plugin #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These files will be temporary ... so how to i make sure they are not delete? mmm.. i should be OK ... right? One choice would be to check YET again if the file passed is still there on the CSV queue worker and load if from a string there? mmmm ...
@alliomeria there is a question for you at line 583. I have tons of those. For now i assuming "only process children" if the row containing it was processed. But what if we want to process anyways? Also. another issue i will encounter is: Delete processed ADOs... i will have to parse again each CSV attached to the main one?
DiegoPino
added
enhancement
Irrelevant but my eye (left one) was twitching
Note: I will also allow any plugin to set Fixed values and skip steps of the AMI setup main form That way we can totally avoid user input on things that need to be one way (like here)
… importer Except it forces CSV and tries to save in private ... if that goes well i might shift all to private
No longer waiting for all CSV rows to be read if that is the case.
adds the $plugin_instance->stepFormAlter($form, $form_state, $this->store, $this->step); only if step >1. Could be really larger than 2 (bc step 2 is the actual plugin form .. but this would also allow a plugin to not define that, but add complex logic for its own $plugin_instance->interactiveForm($parents, $form_state) instead of $plugin_instance->interactiveForm($parents, $form_state);
…custom we will only parse 'ArchiveContainer' 'ArchiveComponent'
only via templates
@alliomeria will give it a spin tomorrow AM. I had to make some hard choices. Automatic UUID generation at this moment of the project is a bad idea. Anything can go wrong, missing ID to generate, repeated UUIDs on the parents, etc, etc. So i will better make the scrip that generates the EAD structure well formed and public and all UUID generation will have there. Once we have tested this the actual script will become part of the process (one can uploads XMLs instead of a CSV)
@alliomeria this has not been my best week. Testing now again nested ingests. Sorry :(
or we will end with 500 Mbytes of stuff that is unneeded on every batch run
See #200 or #200 Note. I think we should also on replace/append and even on full replace log the JSON diff the way we do via VBO replace. @alliomeria thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #195 .
Includes.
ap:tasksare not overridden by our standardized defaults when updating via an AMI update via replace operation #200