fix: false negatives and positives in no-reversed-media-syntax
#473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lse-negatives-no-reversed-media-syntax
lumirlumir
changed the title
Heading/TableCell false negatives in no-reversed-media-syntaxno-reversed-media-syntax
lumirlumir
commented
Jul 22, 2025
Comment on lines
+106
to
+171
| function findReversedMediaSyntax(node) { | ||
| const text = context.sourceCode.getText(node); | ||
| const skipRanges = findSkipRanges(node); | ||
| let match; | ||
|
|
||
| while ((match = reversedPattern.exec(text)) !== null) { | ||
| const [reversedSyntax, label, url] = match; | ||
| const matchIndex = match.index; | ||
| const matchLength = reversedSyntax.length; | ||
|
|
||
| if ( | ||
| isInSkipRange( | ||
| matchIndex + node.position.start.offset, | ||
| skipRanges, | ||
| ) | ||
| ) { | ||
| continue; | ||
| } | ||
|
|
||
| const { | ||
| lineOffset: startLineOffset, | ||
| columnOffset: startColumnOffset, | ||
| } = findOffsets(text, matchIndex); | ||
| const { | ||
| lineOffset: endLineOffset, | ||
| columnOffset: endColumnOffset, | ||
| } = findOffsets(text, matchIndex + matchLength); | ||
|
|
||
| const baseColumn = 1; | ||
| const nodeStartLine = node.position.start.line; | ||
| const nodeStartColumn = node.position.start.column; | ||
| const startLine = nodeStartLine + startLineOffset; | ||
| const endLine = nodeStartLine + endLineOffset; | ||
| const startColumn = | ||
| (startLine === nodeStartLine | ||
| ? nodeStartColumn | ||
| : baseColumn) + startColumnOffset; | ||
| const endColumn = | ||
| (endLine === nodeStartLine ? nodeStartColumn : baseColumn) + | ||
| endColumnOffset; | ||
|
|
||
| context.report({ | ||
| loc: { | ||
| start: { | ||
| line: startLine, | ||
| column: startColumn, | ||
| }, | ||
| messageId: "reversedSyntax", | ||
| fix(fixer) { | ||
| const startOffset = | ||
| node.position.start.offset + matchIndex; | ||
| const endOffset = startOffset + matchLength; | ||
|
|
||
| return fixer.replaceTextRange( | ||
| [startOffset, endOffset], | ||
| `[${label}](${url})`, | ||
| ); | ||
| end: { | ||
| line: endLine, | ||
| column: endColumn, | ||
| }, | ||
| }); | ||
| } | ||
| }, | ||
| messageId: "reversedSyntax", | ||
| fix(fixer) { | ||
| const startOffset = | ||
| node.position.start.offset + matchIndex; | ||
| const endOffset = startOffset + matchLength; | ||
|
|
||
| return fixer.replaceTextRange( | ||
| [startOffset, endOffset], | ||
| `[${label}](${url})`, | ||
| ); | ||
| }, | ||
| }); | ||
| } | ||
| } |
There was a problem hiding this comment.
The git diff shows some changes here, but I didn't change the logic itself.
I just wrapped the existing logic in a single function and reused it.
|
It looks like there's a merge conflict. Can you take a look? |
|
I've resolved the merge conflicts. |
nzakas
approved these changes
Jul 30, 2025
github-project-automation
bot
moved this from Second Review Needed
to Complete
in Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Hello,
In this PR, I have addressed both false negatives and false positives in
no-reversed-media-syntax.False Negatives:
Currently, the
no-reversed-media-syntaxrule does not detect error-prone syntax inHeadingandTableCellnodes.AST
HeadingandTableCellnodes can containLinkorImagenodes, but the current logic does not report them.This behavior is also consistent with Markdownlint:
So, I've fixed them to be reported correctly.
False Positives:
For cases involving HTML nodes, the logic should not report them; however, the current logic is producing false positives.
So, I've added HTML nodes to the skip range and excluded them when reporting errors.
For example:
What changes did you make? (Give an overview)
Related Issues
Is there anything you'd like reviewers to focus on?