-
-
Notifications
You must be signed in to change notification settings - Fork 52
chore: switch to googleapis/release-please-action
#243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
lumirlumir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generator-eslint/.github/CODEOWNERS
Line 1 in 0d27cc2
| .github/workflows/release-please.yml @eslint/eslint-tsc |
Could we also update the CODEOWNERS file above to include the following?
+ .release-please-manifest.json @eslint/eslint-tsc
.github/workflows/release-please.yml @eslint/eslint-tscReferences:
.release-please-manifest.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this filename has an extra U+200E character at the start.
release-please-config.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as #243 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks. I have no further comments.
Just waiting for @mdjermanovic's comments to be resolved.
Prerequisites checklist
What is the purpose of this pull request?
Switches to https://github.com/googleapis/release-please-action as https://github.com/google-github-actions/release-please-action is deprecated.
What changes did you make? (Give an overview)
.github/workflows/release-please.yml.Related Issues
Closes #239
Is there anything you'd like reviewers to focus on?