Skip to content

Conversation

@Pixel998
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request?

Switches to https://github.com/googleapis/release-please-action as https://github.com/google-github-actions/release-please-action is deprecated.

What changes did you make? (Give an overview)

  • Updated .github/workflows/release-please.yml.
  • Adopted v4 best practices by using a manifest/config.

Related Issues

Closes #239

Is there anything you'd like reviewers to focus on?

Copy link
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.github/workflows/release-please.yml @eslint/eslint-tsc

Could we also update the CODEOWNERS file above to include the following?

+ .release-please-manifest.json @eslint/eslint-tsc
  .github/workflows/release-please.yml @eslint/eslint-tsc

References:

@lumirlumir lumirlumir moved this from Needs Triage to Implementing in Triage Nov 20, 2025
Copy link
Member

@mdjermanovic mdjermanovic Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this filename has an extra U+200E character at the start.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as #243 (comment)

Copy link
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks. I have no further comments.

Just waiting for @mdjermanovic's comments to be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Implementing

Development

Successfully merging this pull request may close these issues.

4 participants