-
-
Notifications
You must be signed in to change notification settings - Fork 29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pkg. engines
need to be updated. :)
5e6dad7
to
a73077c
Compare
@@ -5,7 +5,7 @@ | |||
"main": "lib/index.js", | |||
"version": "4.0.3", | |||
"engines": { | |||
"node": ">=4.0.0" | |||
"node": ">=8.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aladdin-add Thanks for the reminder!
For the team: do we care about this matching eslint/eslint
? It looks like we treat each project independently in this regard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the packages that eslint depended should have a same/wider range. so I think it's fine to be as is.
TSC Summary
TSC QuestionDo we want to accept this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
For reference, Webpack 5 has dropped Node 6, too. (webpack/webpack#7593)
Ah, in that case, I think we should be okay. @ilyavolodin just want to make sure you feel okay with this. |
This was discussed during today's TSC meeting and the resolution was to accept this. |
refs #53
Now that we've dropped support for Node <8, I think we should also drop support here. I'd like to merge this, merge #53, and then cut a major release.
Edit: @ilyavolodin made me aware that Webpack depends oneslint-scope
directly, and it appears that they still support Node@6. Maybe this isn't something we want to do yet?This was discussed by the TSC, who resolved to accept this.