Skip to content
This repository was archived by the owner on Aug 15, 2024. It is now read-only.

Breaking: drop support for Node v6 #54

Merged
merged 2 commits into from
Jul 19, 2019
Merged

Conversation

kaicataldo
Copy link
Member

@kaicataldo kaicataldo commented Jun 27, 2019

refs #53

Now that we've dropped support for Node <8, I think we should also drop support here. I'd like to merge this, merge #53, and then cut a major release.

Edit: @ilyavolodin made me aware that Webpack depends on eslint-scope directly, and it appears that they still support Node@6. Maybe this isn't something we want to do yet?

This was discussed by the TSC, who resolved to accept this.

Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkg. engines need to be updated. :)

@kaicataldo kaicataldo force-pushed the drop-node-6-support branch from 5e6dad7 to a73077c Compare June 27, 2019 16:46
@@ -5,7 +5,7 @@
"main": "lib/index.js",
"version": "4.0.3",
"engines": {
"node": ">=4.0.0"
"node": ">=8.0.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aladdin-add Thanks for the reminder!

For the team: do we care about this matching eslint/eslint? It looks like we treat each project independently in this regard.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the packages that eslint depended should have a same/wider range. so I think it's fine to be as is.

@kaicataldo
Copy link
Member Author

TSC Summary

eslint-scope currently supports Node >=4.0.0. This PR drops support for Node 4 & 6 since we have dropped support in ESLint core. There were some concerns raised about doing this, because Webpack relies on eslint-scope directly. I'm not sure how to proceed with this, so figured it was good to have the TSC make a decision.

TSC Question

Do we want to accept this?

Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

For reference, Webpack 5 has dropped Node 6, too. (webpack/webpack#7593)

@kaicataldo
Copy link
Member Author

Ah, in that case, I think we should be okay. @ilyavolodin just want to make sure you feel okay with this.

@kaicataldo
Copy link
Member Author

This was discussed during today's TSC meeting and the resolution was to accept this.

@kaicataldo kaicataldo merged commit ee9f7c1 into master Jul 19, 2019
@kaicataldo kaicataldo deleted the drop-node-6-support branch July 19, 2019 16:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants