Repository navigation
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Property-name diagnostic range src/rules/prefer-logical-properties.js, tests/rules/prefer-logical-properties.test.js |
The diagnostic range now covers only the property name. Tests update expected end columns for margin-top, MARGIN-TOP, and padding-top. |
Estimated code review effort: 2 (Simple) | ~8 minutes
Change: Bug fix
Suggested labels: bug
Suggested reviewers: azat-io
Merge Risk: 
Minimal · up to 4daef
-
The change highlights the property name rather than the whole declaration, with matching test expectations. No actionable merge-blocking risk was identified; merge after normal checks pass.
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files.
-
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
DMartens
left a comment
There was a problem hiding this comment.
Changes LGTM, thanks. Leaving open for others to review.
Prerequisites checklist
AI acknowledgment
Check all that apply.
What did you do?
What did you expect to happen?
An error on
margin-leftonly, the part that the message names and the suggestion replaces.What actually happened?
The error covered the whole declaration.
What is the purpose of this pull request?
This PR makes
prefer-logical-propertiesreport physical properties at the property name instead of across the whole declaration.What changes did you make? (Give an overview)
Ended the property report's location at the property name instead of using the
Declarationnode's location.Related Issues
Is there anything you'd like reviewers to focus on?
Summary by CodeRabbit