Skip to content

feat: check text-align-last in prefer-logical-properties - #610

Merged
DMartens merged 1 commit into
mainfrom
feat/prefer-logical-properties-text-align-last
Nov 1, 2026
Merged

DMartens merged 1 commit into
mainfrom
feat/prefer-logical-properties-text-align-last

Conversation

@Pixel998

Copy link
Copy Markdown
Contributor

Prerequisites checklist

AI acknowledgment

Check all that apply.

  • I did not use AI to generate this PR.
  • I used AI to write or edit the description of this PR (including translation).
  • I used AI to understand the codebase.
  • I used AI to write or edit the files in this PR and I reviewed the files.

What did you do?

/* eslint css/prefer-logical-properties: "error" */

a {
	text-align-last: right;
}

What did you expect to happen?

right to be reported, as it is for text-align.

What actually happened?

No error.

What is the purpose of this pull request?

This PR makes prefer-logical-properties check text-align-last, so left and right are reported with start and end as suggestions, as they already are for text-align.

What changes did you make? (Give an overview)

Added text-align-last to the value replacements, with the same mappings as text-align.

Related Issues

Is there anything you'd like reviewers to focus on?

@coderabbitai

coderabbitai Bot commented Oct 31, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 28 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML; Path: .coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cf468a75-05f2-4998-bbd0-8a5c3d7ab3ea
Commits

Reviewing files that changed from the base of the PR and between 79e7d51 and 19feb13.

Files selected for processing: 2
  • src/rules/prefer-logical-properties.js
  • tests/rules/prefer-logical-properties.test.js
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@Pixel998 Pixel998 moved this from Needs Triage to Implementing in Triage Oct 31, 2026

@DMartens DMartens left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thanks.

@DMartens
DMartens merged commit 61013dd into main Nov 1, 2026
39 checks passed
@DMartens
DMartens deleted the feat/prefer-logical-properties-text-align-last branch November 1, 2026 10:04
@github-project-automation github-project-automation Bot moved this from Implementing to Complete in Triage Nov 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

2 participants