Repository navigation
Conversation
…ical-properties`
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Remove value-replacement mappings src/rules/prefer-logical-properties.js |
The rule no longer handles the caption-side and box-orient value-replacement mappings. |
Estimated code review effort: 1 (Trivial) | ~4 minutes
Change: Bug fix
Suggested labels: bug
Suggested reviewers: azat-io
Merge Risk: 
Minimal · up to 4fa86
-
The rule stops suggesting logical replacements for these caption-side and box-orient values. No actionable merge-blocking risk is identified; merge after normal checks pass.
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files.
-
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Prerequisites checklist
AI acknowledgment
Check all that apply.
What did you do?
What did you expect to happen?
No errors.
What actually happened?
Both were reported:
Expected logical value 'inline-start' instead of 'left'.andExpected logical value 'block-axis' instead of 'vertical'.no-invalid-propertiesreportscaption-side: leftand the suggestedcaption-side: inline-startas invalid.What is the purpose of this pull request?
This PR stops
prefer-logical-propertiesfrom checkingcaption-sideandbox-orient, because no browser supports the declarations it reported or the ones it suggested.What changes did you make? (Give an overview)
Removed the
caption-sideandbox-oriententries frompropertyValuesReplacements.Related Issues
Is there anything you'd like reviewers to focus on?
Summary by CodeRabbit
caption-side: left/righttoinline-start/inline-endorbox-orient: horizontal/verticaltoinline-axis/block-axis. These property-value combinations are no longer covered by the rule’s replacement mappings.