Skip to content

fix: drop caption-side and box-orient in prefer-logical-properties - #609

Open
Pixel998 wants to merge 1 commit into
mainfrom
fix/prefer-logical-properties-caption-side-box-orient
Open

Pixel998 wants to merge 1 commit into
mainfrom
fix/prefer-logical-properties-caption-side-box-orient

Conversation

@Pixel998

@Pixel998 Pixel998 commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Prerequisites checklist

AI acknowledgment

Check all that apply.

  • I did not use AI to generate this PR.
  • I used AI to write or edit the description of this PR (including translation).
  • I used AI to understand the codebase.
  • I used AI to write or edit the files in this PR and I reviewed the files.

What did you do?

/* eslint css/prefer-logical-properties: "error" */

a {
	caption-side: left;
	box-orient: vertical;
}

What did you expect to happen?

No errors.

What actually happened?

Both were reported: Expected logical value 'inline-start' instead of 'left'. and Expected logical value 'block-axis' instead of 'vertical'. no-invalid-properties reports caption-side: left and the suggested caption-side: inline-start as invalid.

What is the purpose of this pull request?

This PR stops prefer-logical-properties from checking caption-side and box-orient, because no browser supports the declarations it reported or the ones it suggested.

What changes did you make? (Give an overview)

Removed the caption-side and box-orient entries from propertyValuesReplacements.

Related Issues

Is there anything you'd like reviewers to focus on?

Summary by CodeRabbit

  • Changes
    • The logical-properties rule no longer maps caption-side: left/right to inline-start/inline-end or box-orient: horizontal/vertical to inline-axis/block-axis. These property-value combinations are no longer covered by the rule’s replacement mappings.

@eslint-github-bot eslint-github-bot Bot added the bug Something isn't working label Oct 31, 2026
@github-project-automation github-project-automation Bot moved this to Needs Triage in Triage Oct 31, 2026
@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML; Path: .coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1e84f729-9128-4a15-abbe-88e1e8bd39f9
Commits

Reviewing files that changed from the base of the PR and between 79e7d51 and 4fa8661.

Files selected for processing: 1
  • src/rules/prefer-logical-properties.js

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

Walkthrough

The rule no longer maps caption-side: left/right or box-orient: horizontal/vertical to logical values.

Changes: Logical property replacements

Layer / File(s) Summary
Remove value-replacement mappings
src/rules/prefer-logical-properties.js
The rule no longer handles the caption-side and box-orient value-replacement mappings.

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Bug fix

Suggested labels: bug

Suggested reviewers: azat-io

Merge Risk: Minimal · up to 4fa86

The rule stops suggesting logical replacements for these caption-side and box-orient values. No actionable merge-blocking risk is identified; merge after normal checks pass.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: removing the caption-side and box-orient mappings from prefer-logical-properties.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files.

Finishing Touches
Generate docstrings
  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@Pixel998 Pixel998 moved this from Needs Triage to Implementing in Triage Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Implementing

Development

Successfully merging this pull request may close these issues.

1 participant