-
-
Notifications
You must be signed in to change notification settings - Fork 24
feat: add @namespace validation to no-invalid-at-rule-placement rule #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @TKDev7, are you still working on this? |
@snitin315 #171 needs to be merged first. |
Done |
Hi, @TKDev7 Could you please add appropriate descriptions to the PR template? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good. Just want to clarify some things in the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Prerequisites checklist
What is the purpose of this pull request?
This pull request implements and enforces the correct placement of the
@namespace
at-rule in CSS, according to the specification:@namespace
must be placed before all other rules, except@charset
and@import
.What changes did you make? (Give an overview)
@namespace
.Related Issues
Is there anything you'd like reviewers to focus on?