Skip to content

feat: add @namespace validation to no-invalid-at-rule-placement rule #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 23, 2025

Conversation

TKDev7
Copy link
Contributor

@TKDev7 TKDev7 commented Jun 26, 2025

Prerequisites checklist

What is the purpose of this pull request?

This pull request implements and enforces the correct placement of the @namespace at-rule in CSS, according to the specification: @namespace must be placed before all other rules, except @charset and @import.

What changes did you make? (Give an overview)

  • Updated the no-invalid-at-rule-placement rule to check for the correct placement of @namespace.
  • Added tests to verify correct and incorrect placements of @namespace and other at-rules.
  • Updated documentation to reflect the new rule behavior and provide usage examples.

Related Issues

Is there anything you'd like reviewers to focus on?

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jun 26, 2025
@TKDev7 TKDev7 marked this pull request as draft June 26, 2025 14:07
@nzakas nzakas moved this from Needs Triage to Implementing in Triage Jul 2, 2025
@snitin315
Copy link
Contributor

Hi @TKDev7, are you still working on this?

@TKDev7
Copy link
Contributor Author

TKDev7 commented Jul 7, 2025

@snitin315 #171 needs to be merged first.

@snitin315
Copy link
Contributor

Done

@TKDev7 TKDev7 marked this pull request as ready for review July 17, 2025 03:12
@lumirlumir lumirlumir added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jul 17, 2025
@lumirlumir
Copy link
Member

Hi, @TKDev7

Could you please add appropriate descriptions to the PR template?

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. Just want to clarify some things in the docs.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nzakas nzakas merged commit 26b902c into eslint:main Jul 23, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this from Implementing to Complete in Triage Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion feature
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

4 participants